[pull] master from moby:master #499
Open
+1,936,918
−629,396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendor: update golang.org/x/xxx dependencies
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
remove uses of deprecated go-archive consts
- remove aliases for deprecated types and functions - chrootarchive: remove redundant "init" mitigation for CVE-2019-14271 - xattr: Fix OS matching full diff: moby/go-archive@v0.1.0...v0.2.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vendor: github.com/moby/go-archive v0.2.0
- Streamline build tags: remove tinygo, cgo - Fix race condition in refCount initialization - Simplify utimens. Use `syscall.UtimesNano` to avoid a macOS `go:linkname`. - Change version policy to two versions. - Update Wasm 2.0 spec tests. - Use golang.org/x/sys full diff: wazero/wazero@v1.10.1...v1.11.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
vendor: github.com/tetratelabs/wazero v1.11.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
api/types/network: remove use of "reflect" in test
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
The API documentation had incorrect descriptions for these fields: - `/version` endpoint's `Arch` field was described generically but actually returns the Go runtime's GOARCH value - `/info` endpoint's `Architecture` field incorrectly stated it returns GOARCH, but it actually returns the OS-reported hardware architecture (equivalent to `uname -m`) This commit corrects the descriptions to accurately reflect the implementation. Fixes #49594 Signed-off-by: majiayu000 <1835304752@qq.com>
Update the memory stats documentation to clarify differences between cgroups v1 and v2: - Add cgroups v2 formula for calculating used_memory using inactive_file instead of cache field which is not available in v2 - Update memory_stats.stats description to explain that field names differ between v1 (cache, rss, mapped_file) and v2 (file, anon, inactive_file) Fixes #43810 Signed-off-by: majiayu000 <1835304752@qq.com>
The API documentation incorrectly stated that the Data field for secrets and configs should use Base64-url-safe-encoded format (RFC 4648 section 5). However, Docker actually uses standard base64 encoding (RFC 4648 section 4). This caused confusion when users tried to use URL-safe base64 encoding and received "illegal base64 data" errors. Update the documentation to correctly reference RFC 4648 section 4 (standard base64) instead of section 5 (URL-safe base64). Fixes #37671 Signed-off-by: majiayu000 <1835304752@qq.com>
Document that when a health check command exceeds its configured timeout, the process is forcibly terminated. This clarifies the behavior for users who need predictable handling of hung health check commands. Fixes #45927 Signed-off-by: majiayu000 <1835304752@qq.com>
Clarify what the /images/{name}/tag endpoint does by explaining that
it creates an additional reference (tag) to the source image, and that
existing tags will be overwritten.
The previous description "Tag an image so that it becomes part of a
repository" was unclear about what the operation actually does.
Fixes #22402
Signed-off-by: majiayu000 <1835304752@qq.com>
Add nil check before calling EventsService.Close() to prevent panic when daemon.EventsService is not initialized during shutdown. Signed-off-by: jinda.ljd <jinda.ljd@alibaba-inc.com>
…l-modules ci: run golangci-lint for each Go module
fix: prevent potential panic in Shutdown when EventsService is nil
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: majiayu000 <1835304752@qq.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
migrate TestAPIImageImportBadSrc to integration test
The "param" field was only used to generate the error-message, and the produced error-message was missing a space so we may as well just inline it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Michael Smithhisler <smithhisler.mike@gmail.com>
Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
Do not update "api" and "client" module dependencies. We keep dependency versions low for these to stick with "MVS" (Minimum Version Selection); https://research.swtch.com/vgo-mvs Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
client: implement WithResponseHook option
typo: called to caller
chore(deps): update actions/cache action to v5
Signed-off-by: Mend Renovate <bot@renovateapp.com>
Pull request 50956 (88adc28) updated various types in the API module from a string to a `netip.Prefix` or `netip.Addr`. A side-effect of this was that zero values would no longer be omitted, and instead marshaled as an empty string; package main import ( "encoding/json" "fmt" "net/netip" ) type Foo struct { OmitEmpty netip.Prefix `json:",omitempty"` OmitZero netip.Prefix `json:",omitzero"` } func main() { out, _ := json.Marshal(Foo{}) fmt.Println(string(out)) } The above produces `{"OmitEmpty":""}`, not omitting the empty address. This patch; - updates most types to use `omitzero` instead of `omitempty`. - adds explicit `json` names to fields. There's one type remaining that uses `omitzero`, but it's generated by go-swagger, which currently doesn't support `omitzero`; the `PortSummary.IP`; https://github.com/moby/moby/blob/335f60509fde10cf8a148ef96f67faeba6517a4b/api/types/container/port_summary.go#L12-L20 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ci: renovate: disable for api and client modules and use JSON5 format
Explicitly reject multiple JSON documents in authentication payloads instead of silently ignoring them. This helps notify users when the authentication payload is incorrectly formatted. Signed-off-by: hiroto.toyoda <hiroto.toyoda@dena.com>
Setting the default host was implicitly handled in `normalizeHosts`; if no hosts were provided, an empty entry was added to the list of hosts, then passed through to `opts.ParseHost`, which handled an empty value to set the default location (depending on TLS being enabled or XDG paths to be used (when running with RootlessKit). This patch makes the logic less magical: - If no hosts are configured by the user (through CLI-flags or daemon.json), then we append the default location. - The handling for TLS listeners is open-coded for now; we need to decide if we want to preserve this behavior (magically using TCP instead of a unix-socket or named pipe if TLS is enabled). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Merge some of the test-cases into TestParseDockerDaemonHost. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…-6.x chore(deps): update actions/checkout action to v6
api/types: use "omitzero" instead of "omitempty" for "netip" fields
inspect: add API-version gate for image identity
loadDaemonCliConfig: explicitly set default host
api/pkg/authconfig: reject multiple JSON documents in Decode
Prepare docker-v29.2.0 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Drop replace rules and cut API v1.53
full diff: https://github.com/moby/moby/api/compare/2d8289cbf32e...v1.53.0 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vendor: github.com/moby/moby/api v1.53.0
full diff: https://github.com/moby/moby/client/compare/2d8289cbf32e...v0.2.2 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vendor: github.com/moby/moby/client v0.2.2
When error during daemon initialization fails before the events manager
is created the daemon will panic instead of erroring out cleanly with
an actual error message.
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x194fcec]
goroutine 1 [running, locked to thread]:
github.com/moby/moby/v2/daemon/events.(*Events).Close(...)
/go/src/github.com/docker/docker/daemon/events/events.go:157
github.com/moby/moby/v2/daemon.(*Daemon).Shutdown(0x40001bf908, {0x2d664f0, 0x44c87e0})
/go/src/github.com/docker/docker/daemon/daemon.go:1505 +0x3bc
github.com/moby/moby/v2/daemon.NewDaemon.func1()
/go/src/github.com/docker/docker/daemon/daemon.go:907 +0x44
github.com/moby/moby/v2/daemon.NewDaemon({0x2d66560, 0x4000051c20}, 0x40004a6108, 0x40006fe810, 0x4000318700)
/go/src/github.com/docker/docker/daemon/daemon.go:1371 +0x2130
github.com/moby/moby/v2/daemon/command.(*daemonCLI).start(0x4000051bd0, {0x2d664f0, 0x44c87e0})
/go/src/github.com/docker/docker/daemon/command/daemon.go:264 +0xb90
github.com/moby/moby/v2/daemon/command.runDaemon(...)
/go/src/github.com/docker/docker/daemon/command/docker_unix.go:13
github.com/moby/moby/v2/daemon/command.newDaemonCommand.func1(0x4000381808, {0x40006ac780?, 0x7?, 0x287f0b1?})
/go/src/github.com/docker/docker/daemon/command/docker.go:48 +0xb0
github.com/spf13/cobra.(*Command).execute(0x4000381808, {0x4000050060, 0x4, 0x4})
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1015 +0x7d4
github.com/spf13/cobra.(*Command).ExecuteC(0x4000381808)
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1148 +0x350
github.com/spf13/cobra.(*Command).Execute(...)
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1071
github.com/spf13/cobra.(*Command).ExecuteContext(...)
/go/src/github.com/docker/docker/vendor/github.com/spf13/cobra/command.go:1064
github.com/moby/moby/v2/daemon/command.daemonRunner.Run({0x2d35440?}, {0x2d664f0, 0x44c87e0})
/go/src/github.com/docker/docker/daemon/command/docker.go:97 +0x6c
main.main()
/go/src/github.com/docker/docker/cmd/dockerd/main.go:35 +0x108
```
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
daemon: Fix panic in shutdown after daemon init fails
This action has no tagged releases, so Renovate would open a PR for every new commit. The action is still experimental and frequently receives commits that would trigger unnecessary update PRs. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
renovate: ignore docker/github-builder-experimental
daemon: ignore duplicate task exit events in daemon state
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
daemon/pkg/plugin/v2: use namespace consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )