OpenID: Add claims to Well know #967
Conversation
Some client can't use userinfo, and get propelty from claims. Add claims key inside wellknow.
AndreaGreco
changed the title
Codecov Report
@@ Coverage Diff @@
## master #967 +/- ##
==========================================
+ Coverage 96.59% 96.62% +0.02%
==========================================
Files 31 31
Lines 1732 1746 +14
==========================================
+ Hits 1673 1687 +14
Misses 59 59
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
| our custom validator:: | ||
|
|
||
| our custom validator. | ||
| Standard claim ``sub`` is included by default, for remove it override ``get_claim_list``:: |
There was a problem hiding this comment.
This is StandardClaims, some application use it for discover available params.
My case application is https://docebo.com
As commented inside code:
https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
There was a problem hiding this comment.
The remark was about the preposition.
|
@AndreaGreco I've been forced to revert this PR because you changed the signature of Please review and resubmit a PR that doesn't change the signature and I'll be happy to review it. Thanks. |
|
Also, please consider my comment: #1068 (comment) |
Description of the Change
Some application, don't use user_info, and read directly by wellknow
Add to wellknow related key and changed class for support list and custom claims
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS