-
Notifications
You must be signed in to change notification settings - Fork 300
Allow users to overwrite get_serializer_class while using related urls
#860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ff191c8
This attempt to fix the issues breaks tests
uliSchuster 9f69484
Removed misleading comment
uliSchuster a2b5704
bein more explicit about the changes
uliSchuster 5c4cb88
Use correct serializer for rendering
uliSchuster 0366ceb
Add provision for tests
uliSchuster 7e577d9
Describe the fix.
uliSchuster 67d79ff
Fixed failing tests
uliSchuster 41785b8
Update CHANGELOG.md
sliverc e27b7a4
Fixed linting issues
uliSchuster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use correct serializer for rendering
Ensure that the correct resource is returned during rendering, which in turn requires to use the correct serializer, depending on if it is a related resource or the parent resource. sliverc pointed out the issue here.
- Loading branch information
commit 5c4cb88a38ef809f182c5fc6eb25ee6d3db74fd6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.