-
Notifications
You must be signed in to change notification settings - Fork 300
Reimplement SerializerMethodResourceRelatedField #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement SerializerMethodResourceRelatedField #781
Conversation
38e7dba to
3664a01
Compare
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
+ Coverage 97.21% 97.32% +0.11%
==========================================
Files 55 56 +1
Lines 2874 2920 +46
==========================================
+ Hits 2794 2842 +48
+ Misses 80 78 -2
Continue to review full report at Codecov.
|
sliverc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this. This looks really good. There is currently no documentation about this field though so could you add an example into the documentation and add a changelog entry?
Thanks.
3664a01 to
4f79464
Compare
sliverc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thanks.
Description of the Change
Fixes #639 - interface not consistent with
SerializerMethodFieldFixes #779 - no enforcement of
read_onlyFixes #780 - broken
parentchainChecklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS