Skip to content

Modify exception_handler for a string error like AuthenticationError #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2015
Merged

Modify exception_handler for a string error like AuthenticationError #73

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536bed6
Modify exception_handler for a string error like AuthenticationError
hnakamur Sep 8, 2015
d6d3f3e
Make an error object to conform JSON API spec
hnakamur Sep 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make an error object to conform JSON API spec
  • Loading branch information
@hnakamur
hnakamur committed Sep 8, 2015
commit d6d3f3e582cfa6a9e69ba2f38c94f5e852840173
9 changes: 7 additions & 2 deletions rest_framework_json_api/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,14 @@ def exception_handler(exc, context):
field = format_value(field)
pointer = '/data/attributes/{}'.format(field)
# see if they passed a dictionary to ValidationError manually
# or a string in case of AuthenticationError
if isinstance(error, dict) or isinstance(error, str):
if isinstance(error, dict):
errors.append(error)
# or a string in case of AuthenticationError
elif isinstance(error, str):
# An error MUST be a JSON object in JSON API spec
errors.append({
'detail': error
})
else:
for message in error:
errors.append({
Expand Down