Skip to content

Conversation

@abdulhaq-e
Copy link
Contributor

The key for all of this is the two functions in test.utils .

I also disabled the test_multiple_id_mixin. I have an almost complete solution for filtering which is compliant with the specifications.

@abdulhaq-e abdulhaq-e force-pushed the feature/test-all-versions branch from c1d1f5b to 55c60f4 Compare September 4, 2015 06:19
@abdulhaq-e abdulhaq-e force-pushed the feature/test-all-versions branch from 55c60f4 to 5562e61 Compare September 4, 2015 07:09
@abdulhaq-e
Copy link
Contributor Author

So now the failing tests are for drf24 and drf30. Supporting the former is more challenging. However, in my opinion, before attempting to fix those, there needs to be some refactoring. Similar code is repeated in many places and there are some major cases which the renderer can't yet handle. For example, non-paginated lists doesn't work. I fixed it but it needs to be tasted. Supporting drf{24,30} will be much easier then.

@abdulhaq-e abdulhaq-e mentioned this pull request Sep 5, 2015
jsenecal added a commit that referenced this pull request Sep 8, 2015
better handling for unicode, should fix some tests
@jsenecal jsenecal merged commit cc83be0 into django-json-api:feature/test-all-versions Sep 8, 2015
@abdulhaq-e abdulhaq-e deleted the feature/test-all-versions branch September 18, 2015 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants