Skip to content

Use REST framework serializer functionality to extract includes #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2019
Merged

Use REST framework serializer functionality to extract includes #632

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef936f4
Use DRF code to fetch related instance
Anton-Shutik May 16, 2019
9c2afb0
Added test, CHANGELOG
Anton-Shutik May 28, 2019
0afeccf
Changed tests
Anton-Shutik May 31, 2019
82a68b6
Update changelog
sliverc Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed tests
  • Loading branch information
@Anton-Shutik @sliverc
Anton-Shutik authored and sliverc committed Jun 4, 2019
commit 0afeccf2d0ac9c3d20bc725d46bce7154fa0cc85
49 changes: 0 additions & 49 deletions example/tests/test_renderers.py
View file
Open in desktop

This file was deleted.

14 changes: 13 additions & 1 deletion example/tests/unit/test_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@

# serializers
class RelatedModelSerializer(serializers.ModelSerializer):
blog = serializers.ReadOnlyField(source='entry.blog')

class Meta:
model = Comment
fields = ('id',)
fields = ('id', 'blog')


class DummyTestSerializer(serializers.ModelSerializer):
Expand Down Expand Up @@ -137,3 +139,13 @@ class EmptyRelationshipViewSet(views.ReadOnlyModelViewSet):
assert 'relationships' in result['data']
assert 'bio' in result['data']['relationships']
assert result['data']['relationships']['bio'] == {'data': None}


@pytest.mark.django_db
def test_extract_relation_instance(comment):
serializer = RelatedModelSerializer(instance=comment)

got = JSONRenderer.extract_relation_instance(
field=serializer.fields['blog'], resource_instance=comment
)
assert got == comment.entry.blog