Skip to content

Conversation

@mblayman
Copy link
Collaborator

@mblayman mblayman commented May 15, 2018

Fixes #

Description of the Change

This is to see if Travis is still triggered on new PRs.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@mblayman
Copy link
Collaborator Author

@n2ygk It does look like a recent repo config change affected Travis. This test branch is not running either.

@n2ygk
Copy link
Contributor

n2ygk commented May 15, 2018

I'm gonna add a review and see if it unblocks.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if this approval unblocks Travis

@mblayman
Copy link
Collaborator Author

It looks like it is still sitting there. What did we change recently about the repo setup? @jerel or @sliverc, do either of you know what has changed that might block Travis?

@n2ygk
Copy link
Contributor

n2ygk commented May 15, 2018

@mblayman wondering if you are seeing the notes I'm sending @gaker and @jerel in the maintainers list....

@mblayman
Copy link
Collaborator Author

Yep, I saw it in my email just now.

@n2ygk
Copy link
Contributor

n2ygk commented May 15, 2018

Thanks. I see @jerel added us as core. The Travis integration is under @gaker's account. Should we try changing that? There's also a deprecation warning about integrations changing to webhooks.... I've not (yet) configured Travis so I'm probably not the best person to try this....

@n2ygk
Copy link
Contributor

n2ygk commented May 15, 2018

I'm clicking around the travis stuff some. It showed as not an active integration so I activated it.

@n2ygk
Copy link
Contributor

n2ygk commented May 15, 2018

I switched it to run under my profile because it seems to have cleared out @gaker's... Still messing with it.

@n2ygk
Copy link
Contributor

n2ygk commented May 15, 2018

That seems to have fixed it. #430 is building now. Please poke this one with a new commit to see if it also works.

@mblayman
Copy link
Collaborator Author

Yep, it's running.

@mblayman
Copy link
Collaborator Author

Ok, this branch did its job and proved that Travis is back so I'm closing it.

@mblayman mblayman closed this May 15, 2018
@mblayman mblayman deleted the test-branch branch May 15, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants