Fix get_related_resource_type #317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To consider child_relation, eg. the default reverse relationship created by m2m. Otherwise it appears to fall back to the parent serializer type.
Current coverage is 91.55% (diff: 100%)@@ develop #317 diff @@
==========================================
Files 49 49
Lines 2330 2332 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2133 2135 +2
Misses 197 197
Partials 0 0
|
|
Don't think this is actually required, issue seems to be fixed by using provided json_api model serializers. |
|
I still have the problem on reverse Many to Many relations using a Through table and I think this commit may fix the issue ... |
|
Actually it doesn't fix the issue if in the serializer the field is set as read only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To consider child_relation, eg. the default reverse relationship created by m2m. Otherwise it appears to fall back to the parent serializer type.