Skip to content

Conversation

mblayman
Copy link
Collaborator

@mblayman mblayman commented Dec 8, 2016

This branch adds documentation for how to include extra resources
under the included key.

It also adds Sphinx and the extra required dependencies to build
the docs to requirements-development.txt.

I wrote this from the perspective of a user who recently encountered the need to side load extra data and had to scour the source to find it. If it's lacking in additional features that are hidden, I'd love to know and would be happy to add more.

This branch adds documentation for how to include extra resources
under the `included` key.

It also adds Sphinx and the extra required dependencies to build
the docs to `requirements-development.txt`.
@codecov-io
Copy link

codecov-io commented Dec 8, 2016

Codecov Report

Merging #308 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
+ Coverage    91.54%   91.63%   +0.08%     
===========================================
  Files           49       49              
  Lines         2330     2330              
===========================================
+ Hits          2133     2135       +2     
+ Misses         197      195       -2
Impacted Files Coverage Δ
example/models.py 95.65% <ø> (+4.34%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c869f34...040e87c. Read the comment docs.

@mblayman
Copy link
Collaborator Author

mblayman commented Dec 8, 2016

I noticed this Travis build is failing hard. I looked at the errors and they all seem to be network related (which is a relief because I'd be concerned if changing some Markdown broke the build! 😄 ). I'm guessing Travis is having some kind of outage. I would attempt to rebuild, but I don't have permission to do that.

@mblayman
Copy link
Collaborator Author

@jerel I feel a bit weird merging my own PR. Could you take a look at this? I'm trying to clear the PR queue to minimize work in progress so DRF JA doesn't feel like a log jam. Thanks!

@jerel jerel merged commit 7816320 into django-json-api:develop Feb 22, 2017
@jerel
Copy link
Member

jerel commented Feb 22, 2017

Looks good, thanks so much!

@mblayman mblayman deleted the included branch February 22, 2017 19:45
@n1ncha
Copy link

n1ncha commented Feb 23, 2017

Wow this was timely, I just came across the need for this while working on the backend for an ember app. I'm still a little confused on what the need is for both the "included_resources" and "included_serializers". I keep re-reading the source and the the documentation posted above, maybe I will realize what they are for once I work with it for a bit... but any clarification would be most appreciated, thanks.

@jerel
Copy link
Member

jerel commented Feb 23, 2017

@n1ncha included_serializers sets up the serializers while included_resources specifies what is included by default (without having to be specified in the query string)

@n1ncha
Copy link

n1ncha commented Feb 23, 2017

I had been doing ?included= in the querystring (which I discovered in the docs) so I wasn't seeing the difference when included_resources wasn't there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants