Skip to content

Enhancement: Allow relationships to not be included in JSON API response #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Enhancement: Allow relationships to not be included in JSON API response #231

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5235d07
Enhancement: Allow relationships to not be included
TayHobbs Apr 21, 2016
9d21d6b
Version: 2.0.0.beta-2 ~> 2.0.0.beta-3
TayHobbs Apr 21, 2016
ddfef58
Enhancement: support naming API fields differently than model fields
TayHobbs Apr 22, 2016
3051639
Version: 2.0.0.beta-3 ~> 2.0.0.beta-4'
TayHobbs Apr 22, 2016
01b6619
Version: 2.0.0.beta-5 ~> 2.1.0
TayHobbs Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enhancement: support naming API fields differently than model fields
  • Loading branch information
@TayHobbs
TayHobbs committed Apr 22, 2016
commit ddfef58dcbd5e7e072788719a03d0438a47c55fa
9 changes: 6 additions & 3 deletions rest_framework_json_api/renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,13 @@ def extract_included(fields, resource, resource_instance, included_resources):
# For ManyRelatedFields if `related_name` is not set we need to access `foo_set` from `source`
relation_instance_or_manager = getattr(resource_instance, field.child_relation.source)
except AttributeError:
if not hasattr(current_serializer, field.source):
if hasattr(current_serializer, field.source):
serializer_method = getattr(current_serializer, field.source)
relation_instance_or_manager = serializer_method(resource_instance)
elif hasattr(current_serializer.instance, field.source):
relation_instance_or_manager = getattr(current_serializer.instance, field.source)
else:
continue
serializer_method = getattr(current_serializer, field.source)
relation_instance_or_manager = serializer_method(resource_instance)

new_included_resources = [key.replace('%s.' % field_name, '', 1)
for key in included_resources
Expand Down