Support deeply nested includes #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow skipping of intermediate included models
…orm there Fix regression on PY3 caused by unicode_literals
|
Looks great if you ask me, skips me the hassle of writing tests ;) I will cancel mine! |
|
@adaptivdesign Of course you're part of the discussion. I'm pleased you found this great as well. |
|
Credit where credit is due! I see you've implemented polymorphic support as well, I'll have to check that out. Although i'm using an own implementation (django-polymorphism). That is why I needed nested inclusions in the first place, so I could query polymorphic endpoints/relations like this: /projects?include=artproject&include=researchproject |
jerel
added a commit
that referenced
this pull request
Feb 22, 2016
Return intermediate resources for leaf includes. Fixes #149
|
@leo-naeka @adaptivdesign thank you both for your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #200, include paths can be compound of many nodes.
When requesting a deeply nested node, all intermediate nodes must be included as well.
This PR is similar to #200 but involves less code base modifications and includes tests.