Skip to content

Include meta section for SerializerMethodResourceRelatedField(many=True) #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2023
Merged

Include meta section for SerializerMethodResourceRelatedField(many=True) #1162

merged 1 commit into from
Jun 28, 2023

Conversation

arttuperala
Copy link
Contributor

Fixes #572

Description of the Change

SerializerMethodResourceRelatedField(many=True) (ManySerializerMethodResourceRelatedField) fields are given a meta section with a count much like ManyRelatedField.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

sliverc
sliverc approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this very old issue. Appreciated. Looks good. Merging.

@sliverc sliverc merged commit 311385e into django-json-api:main Jun 28, 2023
@arttuperala arttuperala deleted the serializer-method-field-meta branch June 29, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SerializerMethodResourceRelatedField does not include meta section in relationship response.
2 participants
@arttuperala @sliverc