Skip to content

Conversation

erichaus
Copy link

No description provided.

@erichaus
Copy link
Author

What do I need to do to make travis CI pass?

@gaker
Copy link
Member

gaker commented Sep 28, 2014

You can run tests with django-admin.py test --settings=example.settings I'll add a note to the readme file with instructions.

@erichaus
Copy link
Author

doh! sorry about that dude... at first I was changing a locally modified one before I thought to submit a pull request the the main repo... I'll clean it up

@erichaus
Copy link
Author

erichaus commented Oct 1, 2014

Bah! seems more tests not passing... will make another run tomorrow... schedule too busy :/

@erichaus
Copy link
Author

erichaus commented Oct 8, 2014

@gaker updated tests to reflect inflection camel/plural etc... passes. let me know if it needs anything else...

@erichaus
Copy link
Author

erichaus commented Oct 8, 2014

also cleaned up renderer.. seems to work per embers expectation afaik

@erichaus
Copy link
Author

erichaus commented Oct 9, 2014

@jerel - updated to include inflection pluralization/camelization/underscore, fixed render/parse issue, updated tests

@jerel
Copy link
Member

jerel commented Oct 10, 2014

Thanks! At first glance it looks great; we'll try to get it merged shortly

@erichaus
Copy link
Author

@jerel any word on merging that? id like to eliminate my use of fork :)

@jerel
Copy link
Member

jerel commented Oct 29, 2014

@Epicowl sorry about the delay. I'll do my level best to merge this tomorrow evening. Time flies when there's a pull request pending ;)

@erichaus
Copy link
Author

haha ya sorry Im a needy SOB!

@gaker
Copy link
Member

gaker commented Oct 30, 2014

@Epicowl -- I'm trying this on some existing projects we have and things break pretty badly, which makes some sense.

I'm spending some time this morning trying to figure out a way to do backwards compatibility.

@gaker
Copy link
Member

gaker commented Oct 30, 2014

@erichaus
Copy link
Author

@gaker So the main thing this did was added the automatic camelization/underscore/pluralization that ember expects... previously I was using both this library and https://github.com/vbabiy/djangorestframework-camel-case together to get ember and django to talk to eachother, then I realized that the latter functionality could just be added to this library to take care of both... Let me know if that makes sense or not.. Also, I personally haven't played around on the ember side much except that the frontend devs here have said it works as expected...

@erichaus
Copy link
Author

@gaker we could also maybe add a switch by way of a setting that turns on/off the inflection stuff? lmk

@erichaus
Copy link
Author

@gaker just noticed you already added setting.. that looks good

@erichaus erichaus closed this Oct 31, 2014
@erichaus erichaus deleted the develop branch October 31, 2014 01:23
@erichaus
Copy link
Author

@gaker opened new pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants