Test Default DRF Serializer Usage

[scottfisk]

Currently we do not have test coverage for usage of from rest_framework import serializers only from rest_framework_json_api import serializers.

Basic functionality has broken in the past when using from rest_framework import serializers so we should explicitly test that case if we would like to officially support that usage.

[Alig1493]

Is it possible to make a contribution to this? If it is then some guidance would be helpful.

[sliverc]

@Alig1493 Best have a look how the test are written for DJA model vieweset. Create a new python module e.g. test_restframework_serializer.py (maybe there is a better name) and rewrite the test that it uses views and serializer which are directly from package rest_framework instead of rest_framework_json_api.

[Alig1493]

@sliverc the rest framework has a different sort of output in comparison to yours. Do I write tests that matches the request responses to that of the default rest framework serializers?

[sliverc]

@Alig1493 renderer and parsers need to be rest_framework_json_api which are set in settings.py already in the example app. This means the output needs to be json api spec compatible but the serializer and view classes are from rest framework directly.

Hope this clarifies.

[Alig1493]

I've taken a look at the example project and I found some serializer test references in test_renderer_class_methods and test_renderers. Will it be similar to those except the format I'll be using will be from the drf default serializers?

[sliverc]

@Alig1493 I guess test_renderers.py might be the better example to look at. Best give it a try and open a PR. Important is just that it is expected that the result using DRF Serializers will still be a renderdered json api spec.

[Alig1493]

@sliverc I have made an initial attempt mostly taking inspiration from test_renderers.py. I'll be putting up a PR shortly.