Fixes #66 by forcing lipgloss to have no color output#67
Merged
chicoxyzzy merged 1 commit intodispatchrun:mainfrom Jun 23, 2024
Merged
Fixes #66 by forcing lipgloss to have no color output#67chicoxyzzy merged 1 commit intodispatchrun:mainfrom
chicoxyzzy merged 1 commit intodispatchrun:mainfrom
Conversation
chicoxyzzy
approved these changes
Jun 19, 2024
Contributor
chicoxyzzy
left a comment
chicoxyzzy
left a comment
There was a problem hiding this comment.
@chriso pls take a look too
Contributor
|
@Tyl13 may I ask you to rebase the branch on |
Contributor
Author
|
Yeah @chicoxyzzy, I will rebase it either today or tomorrow. |
Contributor
Author
|
@chicoxyzzy rebased. Just needs retested, but tests passed locally on my machine. |
Contributor
|
Thank you @Tyl13! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This imports both lipgloss and termenv, and then uses
SetColorProfile()to usetermenv.Asciiwhich has no-color. I placed this within the setupConfig so it applies to all tests that end up calling thesetupConfig(). It could also be moved to directly withinTestSwitchCommand(). I'm not sure which you would prefer.This fixes Issue #66.