Conversation
chicoxyzzy
force-pushed
the
dispatch_run_tests
branch
2 times, most recently
from
d715f8a to
4d90bc8
Compare
chicoxyzzy
force-pushed
the
dispatch_run_tests
branch
from
4d90bc8 to
757e095
Compare
Comment on lines
+147
to
+148
| // Check if the error is due to context timeout (command running too long) | ||
| if ctx.Err() == context.DeadlineExceeded { |
Contributor
There was a problem hiding this comment.
The context error will always carry information about this being a timeout, could we simplify the code by removing this special case?
Contributor
Author
There was a problem hiding this comment.
It will do exit 1 on printenv ENV_VARIABLE, so I've added this check to be sure that this command exited properly and we can read stderr now to make sure ENV_VARIABLE has correct value (when err is nil).
Contributor
There was a problem hiding this comment.
🤔 I'm not sure I understand the condition in which we would get a timeout, but if you know it's important here it's fine (maybe worth a comment to record that context).
achille-roussel
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial integration tests for the
dispatch runcommand