remove protoCompactOffsetDateTime, add protoOffsetDateTimeFormat#238
Merged
lewisjkl merged 1 commit intodisneystreaming:mainfrom Jul 8, 2025
Merged
Conversation
lewisjkl
approved these changes
Jul 7, 2025
a-morales
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recently added trait
alloy.proto#protoCompactOffsetDateTimeseems to indicate that the default encoding foralloy#OffsetDateTimeshould be a string.However, the underlying type of
alloy#OffsetDateTimeistimestampand the default encoding for timestamp is the compact format according to this commentThis change removes
alloy.proto#protoCompactOffsetDateTimeand addsalloy.proto#protoOffsetDateTimeFormatthat can be used to configure how analloy#OffsetDateTimeshould be encoded when serializing to protobuf.This change supports 2 formats:
PROTOBUF: the timesamp should be encoded usingmessage { int64 seconds = 1; int32 nanos = 2; string zone_offset = 3; }RFC3339_STRING: the timestamp should be encoded as a string using the format described in RFC3339 section 5.6.