Skip to content

Add an encoded character to the GetMenu request tests#210

Merged
kubukoz merged 1 commit intodisneystreaming:mainfrom
Dwolla:simple-rest-encoding-tests
Jul 22, 2025
Merged

Add an encoded character to the GetMenu request tests#210
kubukoz merged 1 commit intodisneystreaming:mainfrom
Dwolla:simple-rest-encoding-tests

Conversation

@bpholt
Copy link
Copy Markdown
Contributor

@bpholt bpholt commented Apr 9, 2025

The Smithy spec says that in HTTP labels used in HTTP request URIs,

Characters not defined as unreserved by RFC 3986 section 2.3 MUST be percent-encoded. That is, all characters except for alphanumerics and -._~.

This PR adds an example of such a character used in the value bound to the GetMenu request's {restaurant} label, along with the expected encoding.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bpholt
Copy link
Copy Markdown
Contributor Author

bpholt commented Apr 9, 2025

I published this locally and used it with disneystreaming/smithy4s#1668. I think that will need to be merged before this can be pulled into smithy4s because otherwise this test case should fail.

@Baccata
Copy link
Copy Markdown
Contributor

Baccata commented Apr 10, 2025

👍 thank you Brian. I'll try to give the smithy4s PR tomorrow a review today (but if I don't I promise I'll do it tomorrow)

@bpholt bpholt force-pushed the simple-rest-encoding-tests branch from e9ddc52 to 4a6c618 Compare July 14, 2025 16:29
@kubukoz kubukoz merged commit f458248 into disneystreaming:main Jul 22, 2025
3 of 4 checks passed
@bpholt bpholt deleted the simple-rest-encoding-tests branch July 22, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants