Skip to content

cc signature checked twice in AcceptToMemoryPool #111

@dimxy

Description

@dimxy

Cryptoconditions signature is checked twice in AcceptToMemoryPool()
Here:

if (!ContextualCheckInputs(tx, state, view, true, STANDARD_SCRIPT_VERIFY_FLAGS, true, txdata, Params().GetConsensus(), consensusBranchId, evalcodeChecker))

and here:

 if (!ContextualCheckInputs(tx, state, view, true, MANDATORY_SCRIPT_VERIFY_FLAGS, true, txdata, Params().GetConsensus(), consensusBranchId, evalcodeChecker))

I think it was supposed it is checked only at the call when STANDARD_SCRIPT_VERIFY_FLAGS is set when non-cc sigs are checked too.
Fix this to avoid extra processing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions