fix github workflow to support new version format and use docker base…#95
Merged
esenkus merged 6 commits intorelease/25.3.xfrom Jun 26, 2025
Merged
fix github workflow to support new version format and use docker base…#95esenkus merged 6 commits intorelease/25.3.xfrom
esenkus merged 6 commits intorelease/25.3.xfrom
Conversation
…d xl-cli over dist
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow to use a Docker-based xl-client instead of downloading the binary directly, and bumps the supported product versions to the new hyphenated format (including 25.3.x).
- Switches from a manual
wgetinstall of xl-cli to running xl-client via Docker - Updates
.github/config/versions.jsonwith new version strings and adds support forrelease/25.3.x
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/Check-official-templates.yaml | Removed manual xl-cli install step, replaced ./xl1 apply with docker run |
| .github/config/versions.json | Updated release version formats for 24.1.x, 24.3.x, 25.1.x and added 25.3.x |
Comments suppressed due to low confidence (2)
.github/workflows/Check-official-templates.yaml:74
- The
docker runinvocation here won’t see your local YAML files or connect to the xl-release container by default. Consider mounting the workspace (e.g.,-v $(pwd):/workspace -w /workspace), configuring a network or link to the xl-release container (or using--network host), and adding--rmto clean up the client container afterward.
docker run xebialabsunsupported/xl-client:$product_version apply -f "$file"
.github/workflows/Check-official-templates.yaml:45
- Using a fixed
sleep 100may either waste time or fail if startup takes longer. Consider polling the service endpoint or using a retry loop/healthcheck to wait for readiness instead.
sleep 100
esenkus
previously approved these changes
Jun 25, 2025
esenkus
approved these changes
Jun 26, 2025
Contributor
|
don't forget to update the description and commit message as this is no longer changing xl-cli to be docker based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating workflow file to use docker based xl-cli than dist based xl-cli, as xebialabsunsupported/xl-client and xebialabsunsupported/xl-release is updated more frequently with latest, and with nightly as well
Updating version.json file with new version file format
Please go the
Previewtab and select the appropriate PR sub-template:Feature