Enable support for STM32U585 #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhu
commented
Feb 10, 2022
anhu
commented
- add a client and server over UART command using DMA.
- use kyber level 1 if HAVE_PQC is defined.
- only call TLSX_UseSupportedCurve() for kyber level 1.
- make sure only one of HAVE_LIBOQS or HAVE_PQM4 is defined.
dgarske
requested changes
Feb 11, 2022
Owner
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
All looks good here. I am not seeing the changes for adding HAVE_PQM4 in this, but I know they are there. Feel free to put up a public wolfSSL PR for this stuff. Might be easier.
IDE/STM32Cube/wolfssl_example.c
Outdated
Owner
There was a problem hiding this comment.
Please add #ifndef HAL_CONSOLE_UART around this.
Author
|
Closing this PR as it has been re-opened as public PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.