Wrap tool invocation in Invoke-OAIFunctionCall with try/catch and ret…#105
Merged
Wrap tool invocation in Invoke-OAIFunctionCall with try/catch and ret…#105
Conversation
…urn informative error on failure
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling to the tool invocation process in Invoke-OAIFunctionCall. When a tool function throws an exception during execution, the error is now caught and returned as an informative message instead of propagating the exception.
Key Changes:
- Wrapped the tool function invocation in a try/catch block to handle execution errors gracefully
- Returns a descriptive error message containing the function name, arguments, and error details when invocation fails
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $result = & $toolFunctionName @toolFunctionArgs | ||
| } | ||
| catch { | ||
| $result = "Error invoking function $($toolFunctionName) with arguments $($toolCall.function.arguments): $_" |
There was a problem hiding this comment.
The error message includes raw arguments from $toolCall.function.arguments which may not be helpful if the arguments were already parsed. Consider using $toolFunctionArgs | ConvertTo-Json -Compress instead to show the actual parsed arguments that were passed to the function.
Suggested change
| $result = "Error invoking function $($toolFunctionName) with arguments $($toolCall.function.arguments): $_" | |
| $result = "Error invoking function $($toolFunctionName) with arguments $($toolFunctionArgs | ConvertTo-Json -Compress): $_" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…urn informative error on failure