Skip to content

ci: Set CONTAINER_NAME within a step. #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FabioLuporini merged 2 commits into from
Jul 25, 2025
Merged

ci: Set CONTAINER_NAME within a step. #2684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e71d4e5
Set CONTAINER_NAME within a step.
ggorman Jul 24, 2025
3e55058
Move the GPU probe into a seperate step to reduce likelyhood of a col…
ggorman Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/docker-devito.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ jobs:
env:
# Use buildkit https://docs.docker.com/develop/develop-images/build_enhancements/ for better build
DOCKER_BUILDKIT: "1"
# Unique container name to avoid clashes across concurrent self-hosted runners
CONTAINER_NAME: testrun-${{ matrix.tag }}-${{ runner.name }}


strategy:
Expand Down Expand Up @@ -55,6 +53,10 @@ jobs:
- name: Checkout devito
uses: actions/checkout@v4

- name: Set per‑runner variables
run: |
echo "CONTAINER_NAME=testrun-${{ matrix.tag }}-$RUNNER_NAME" >> $GITHUB_ENV

- name: Check event name
run: echo ${{ github.event_name }}

Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/pytest-gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,16 @@ jobs:
- name: Export CODECOV token
run: echo "CODECOV_TOKEN=${{ secrets.CODECOV_TOKEN }}" >> "$GITHUB_ENV"

- name: Probe gpu
run: |
# Run a simple driver cmd first (nvidia-smi / rocm-smi)
docker run ${{ matrix.flags }} "${DOCKER_IMAGE}" ${{ matrix.test_drive_cmd }}

- name: Test with pytest
run: |
# Run a simple driver cmd first (nvidia-smi / rocm-smi)
ci_env=$(bash <(curl -s https://codecov.io/env))

docker run ${{ matrix.flags }} "${DOCKER_IMAGE}" ${{ matrix.test_drive_cmd }}

docker run ${{ matrix.flags }} $ci_env -e CI=true "${DOCKER_IMAGE}" \
pytest --cov --cov-config=.coveragerc --cov-report=xml ${{ matrix.test_files }}

Expand Down
Loading