install: switch to dynamic version to avoid _version file issue #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdCaunt
reviewed
May 22, 2025
devito/__init__.py
Outdated
| try: | ||
| __version__ = version("devito") | ||
| except PackageNotFoundError: | ||
| # package is not installed |
Contributor
There was a problem hiding this comment.
Nitpick: Comments should start with capital letter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
+ Coverage 84.06% 91.92% +7.86%
==========================================
Files 239 245 +6
Lines 47893 48461 +568
Branches 4228 4255 +27
==========================================
+ Hits 40259 44547 +4288
+ Misses 6892 3238 -3654
+ Partials 742 676 -66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FabioLuporini
approved these changes
May 23, 2025
Contributor
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.