compiler: Blocked SubDimensions now use root dimension name #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgebisbas
reviewed
May 6, 2025
tests/test_dimension.py
Outdated
| # Check generated code -- expect the gsave equation to be scheduled together | ||
| # in the same loop nest with the fsave equation | ||
| bns, _ = assert_blocking(op, {'x0_blk0', 'x1_blk0', 'ix0_blk0'}) | ||
| bns, _ = assert_blocking(op, {'x0_blk0', 'x2_blk0', 'x1_blk0'}) |
Contributor
There was a problem hiding this comment.
wow, was not expecting this. Is it something we want?
Contributor
Author
There was a problem hiding this comment.
Tbh they could be in any order since it's a set. This change improves code readability when you have subdimensions with long names, since they can just use the name of the parent dimension
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
=======================================
Coverage 91.92% 91.92%
=======================================
Files 245 245
Lines 48396 48396
Branches 4251 4251
=======================================
Hits 44486 44486
Misses 3234 3234
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
georgebisbas
approved these changes
May 7, 2025
FabioLuporini
approved these changes
May 9, 2025
Contributor
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.