-
Notifications
You must be signed in to change notification settings - Fork 248
compiler: Remove counters from subdomains and automatically generate unique names #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2431 +/- ##
==========================================
+ Coverage 87.00% 87.07% +0.06%
==========================================
Files 239 239
Lines 45028 45117 +89
Branches 8406 8427 +21
==========================================
+ Hits 39177 39285 +108
+ Misses 5116 5100 -16
+ Partials 735 732 -3 ☔ View full report in Codecov by Sentry. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
FabioLuporini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking so good
09a44e0 to
4f6d84b
Compare
4f18c77 to
de56705
Compare
de56705 to
1297db1
Compare
|
GTG! |
c989bc0 to
2417758
Compare
2417758 to
6ed3979
Compare
Rather than using counters to ensure subdimensions etc are unique, they should be dynamically renamed during compilation.
Supersedes #2405 .