Skip to content

Conversation

@EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented Jul 30, 2024

Rather than using counters to ensure subdimensions etc are unique, they should be dynamically renamed during compilation.

Supersedes #2405 .

@codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 98.18182% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (28e5ef2) to head (6ed3979).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
devito/ir/equations/algorithms.py 95.52% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
+ Coverage   87.00%   87.07%   +0.06%     
==========================================
  Files         239      239              
  Lines       45028    45117      +89     
  Branches     8406     8427      +21     
==========================================
+ Hits        39177    39285     +108     
+ Misses       5116     5100      -16     
+ Partials      735      732       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking so good

@EdCaunt EdCaunt force-pushed the counters_redux branch 2 times, most recently from 4f18c77 to de56705 Compare September 16, 2024 10:53
@FabioLuporini
Copy link
Contributor

GTG!

@mloubout mloubout merged commit db692d2 into master Oct 3, 2024
@mloubout mloubout deleted the counters_redux branch October 3, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants