fix: add externals with dash to globals (#643) #667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should go vacuum-cleaning now, but here is the short description:
Is
Currently microbundle adds externals to globals - excluding externals with dash (
-). This results in rollup detecting the missing explicit global and defining the global implicitly with the name camel cased. Also will rollup log a warning like:No name was provided for external module 'microbundle-test' in output.globals – guessing 'microbundleTest.Should
Since microbundle is adding the externals to globals by default, it should also include those with a dash as mentioned here - and therefore avoid the
No name was providedrollup warning. Since rollup handles its dash fallback by adding the external camel cased to globals, microbundle should also do the same.The only real difference of this change should be, that we don't get the rollup warning
No name was provided for external modulefor externals with dash.Considerations / Topics for further discussion