feat: add --pkg-main option #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice - @wardpeet and I were looking at breaking those functions out anyway, and I like the way you've done it here! |
developit
approved these changes
Jun 12, 2020
| const { pkg } = options; | ||
| const pkgMain = options['pkg-main']; | ||
|
|
||
| if (!pkgMain) { |
Owner
There was a problem hiding this comment.
I wonder if we could even apply this same logic if the value provided for the --output argument has a file extension. Like microbundle -f umd -o bundle.js would see .js and know to use that name as-is.
Collaborator
Author
There was a problem hiding this comment.
I think this would open to questions:
- Such a new logic could be a "breaking" change because there might be people already using -o with ".js" and expecting it to add the format suffix. If a breaking change would mean that this has to wait for 1.0 I personally would prefer to split this idea into another issue 😇
- If we implement this logic, it should only ever apply if the format option is set with a single value
Collaborator
There was a problem hiding this comment.
Agree with @katywings here. I'm worried that us making too many assumptions will lead to unexpected results for the user. In either case this would be a breaking change.
katywings
force-pushed
the
feature-no-format-suffix
branch
from
5378311 to
859fdba
Compare
marvinhagemeister
approved these changes
Jun 14, 2020
Collaborator
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Awesome, thank you so much for the PR 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this feature is to add a solution for microbundle, to manually disable the package.json / format suffix automations analog to https://twitter.com/Katy_Wings/status/1271189844077748224
The new option
--pkg-mainby default is true - basically notifying the consumer that main entries in package.json will be considered. The consumer can supply--pkg-main falseto disable the microbundle package.json "sideffects".This PR also includes a little refactor of the "main" generation - most of it is the same as before but just moved into separate functions.