Skip to content

Conversation

@merceyz
Copy link
Contributor

@merceyz merceyz commented May 27, 2020

What's the problem this PR addresses?

Microbundle isn't working with Yarn PnP at the moment because it's trying to access dependencies it hasn't declared, and in one instance, not using require.resolve which causes babel to try to load presets from the root of the project.

How did you fix it?

  • Moved @babel/preset-modules from devDependencies to dependencies
  • Added missing dependency @babel/plugin-transform-regenerator
  • Used require.resolve for environmentPreset

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much for fixing that 🙌 💯

@marvinhagemeister marvinhagemeister merged commit 58288ec into developit:master May 27, 2020
@merceyz merceyz deleted the pnp branch May 27, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants