Skip to content

Re-add support for --define @expression=replacement #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marvinhagemeister merged 8 commits into from
Apr 30, 2020
Merged

Re-add support for --define @expression=replacement #588

marvinhagemeister merged 8 commits into from
Apr 30, 2020

Conversation

@developit
Copy link
Owner

@developit developit commented Apr 16, 2020 •
edited
Loading

This should match Terser's global_defs option.

/cc @jviide

@jviide
Copy link
Contributor

jviide commented Apr 20, 2020

LGTM 👍

marvinhagemeister
marvinhagemeister approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 💯

@marvinhagemeister marvinhagemeister merged commit 1c90d6b into master Apr 30, 2020
@marvinhagemeister marvinhagemeister deleted the define-expression-replacement branch April 30, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@developit @jviide @marvinhagemeister