Fix babel cache bleed #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const externalPredicate = new RegExp(`^(${external.join('|')})($|/)`); | ||
| const externalTest = | ||
| external.length === 0 ? () => false : id => externalPredicate.test(id); | ||
| external.length === 0 ? id => false : id => externalPredicate.test(id); |
Collaborator
There was a problem hiding this comment.
does this affect anything?
Owner
Author
There was a problem hiding this comment.
no, just typescript was yelling at me about it.
| return getSizeInfo(code, fileName, options.raw); | ||
| } | ||
| }), | ||
| ).then(results => results.filter(Boolean).join('\n')); |
Collaborator
There was a problem hiding this comment.
I guess the implicit undefined return will work 🤔
Owner
Author
There was a problem hiding this comment.
yeah cause we cast to boolean on L639. this was another TS warning lol
| fs.writeFile( | ||
| getNameCachePath(), | ||
| JSON.stringify(nameCache, null, 2), | ||
| () => {}, |
Collaborator
There was a problem hiding this comment.
same as above, does this change the behavior?
Owner
Author
There was a problem hiding this comment.
same deal, was a typescript warning
ForsakenHarmony
approved these changes
Feb 28, 2020
Collaborator
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2020
Instantiating babel.custom() separately for each output should fix #568, which I believe is caused by cached configuration bleeding from `cjs` into other output targets.
Contributor
Build failed |
Collaborator
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2020
Instantiating babel.custom() separately for each output should fix #568, which I believe is caused by cached configuration bleeding from `cjs` into other output targets.
Contributor
Build failed |
Collaborator
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 12, 2020
Instantiating babel.custom() separately for each output should fix #568, which I believe is caused by cached configuration bleeding from `cjs` into other output targets.
ForsakenHarmony
approved these changes
Mar 12, 2020
Collaborator
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 12, 2020
Instantiating babel.custom() separately for each output should fix #568, which I believe is caused by cached configuration bleeding from `cjs` into other output targets.
This was referenced Apr 5, 2020
Closed
This was
linked to
issues
Apr 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiating babel.custom() separately for each output should fix #568, which I believe is caused by cached configuration bleeding from
cjsinto other output targets.