Strip comments from output #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
We may need to be careful with license comments. Iirc terser or rollup has an option for that 👍
Owner
Author
|
@marvinhagemeister Ideally I would like to extract license comments into a file if they need to be preserved. |
|
I'd love to see this merged, half my bundle is a microsoft license comment from something |
Collaborator
|
@developit I have no permissions to check the GH actions result. Not sure why it's stuck. |
Owner
Author
|
Waiting on PR approval :P |
marvinhagemeister
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.