Support package.json source array #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Come to think of it @developit I'm having second thoughts on this PR... Keen to hear your thoughts. Even though it solves that issue #364, it does mimic the |
Contributor
Author
|
@ForsakenHarmony this one is ready again for another review! 👍 |
Collaborator
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 4, 2019
372: Support package.json source array r=ForsakenHarmony a=maraisr With this PR, I am to solve issue #364, however I believe this shouldn't also need to support `source` that could be either a directory, or a file, or a glob. To keep things simple. fixes #364 Co-authored-by: Marais Rossouw <me@maraisr.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I am to solve issue #364, however I believe this shouldn't also need to support
sourcethat could be either a directory, or a file, or a glob. To keep things simple.fixes #364