Fix importing json and superagent #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you rebase? |
Contributor
Author
|
@ForsakenHarmony done |
Collaborator
|
Will merge in a bit |
Owner
|
Side note: how did we end up with |
Contributor
Author
|
@developit ahaha.. well, it happens to all of us 😬 |
Owner
|
I'm thinking there was some sort of a conditional in there that got cut at some point without me noticing haha |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #211
fix #236
Hi friends 👋 I know it sucks to bundle two changes in one PR, but the superagent fix also includes fixing the json import, so I thought I'd give it a shot anyway 😬
If you want me to split the json fix and the superagent fix, just let me know.
In this PR
rollup-plugin-jsonto support importing json filesuseNodeResolvechecks, because it was always trueKnown issues
After I reordered the plugins, the
build:babelscript started complaining about the#!/usr/bin/env nodeline in the cli.js file. I don't know why that's the case :( I think I'll need some help to figure this one out. For now, I just removed it so it can build and test successfully.