More updates for new DbKi=R8Ki behavior#1
Merged
deslaughter merged 1 commit intodeslaughter:f/del-qukifrom Feb 17, 2023
Merged
Conversation
- change `DBLE` to REAL(*,R8Ki) - remove QuKi from rest of the Sys*.f90 routines - make default double 64 instead of 128 in VS project files DP configurations - consistent variable types in `DCM_expR` and `DCM_SetLogMapForInterpR`and other routines in NWTC_Num.f90
deslaughter
approved these changes
Feb 17, 2023
Owner
|
Thanks for submitting this, I should have done more checking for the other compilers and environments. |
deslaughter
pushed a commit
that referenced
this pull request
Jun 1, 2023
openfast(66108,0x10fb1edc0) malloc: *** error for object 0x7fe4a223a000: pointer being freed was not allocated openfast(66108,0x10fb1edc0) malloc: *** set a breakpoint in malloc_error_break to debug Program received signal SIGABRT: Process abort signal. Backtrace for this error: \#0 0x103a3f33d \#1 0x103a3e76d \#2 0x7fff68c225fc Abort trap: 6
deslaughter
pushed a commit
that referenced
this pull request
Jun 1, 2023
deslaughter
pushed a commit
that referenced
this pull request
Jun 1, 2023
deslaughter
pushed a commit
that referenced
this pull request
Oct 6, 2023
Update regression tests, and merge in latest rc-3.5.1
deslaughter
pushed a commit
that referenced
this pull request
Apr 23, 2024
Automatically build OpenFAST docker images
deslaughter
pushed a commit
that referenced
this pull request
Jul 24, 2024
MD: minor cleanup on Lin Damp feature
andrew-platt
pushed a commit
that referenced
this pull request
Jul 9, 2025
FAST_CreateCheckpoint expects a fixed sized char buffer of size 1025:
`CHARACTER(KIND=C_CHAR), INTENT(IN ) ::
CheckpointRootName_c(IntfStrLen)`. However the c++ is taking a 1 char
string and sending a pointer to that data to the Fortran. The Fortran
`TRANSFER` function then throws a good old:
```
==2684227==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x5120002144e8 at pc 0x557e98358a61 bp 0x7ffc0f87ea90 sp 0x7ffc0f87e248
READ of size 1025 at 0x5120002144e8 thread T0
#0 0x557e98358a60 in memcpy /mnt/vdb/home/jrood/goose/spack/var/spack/stage/spack-stage-llvm-17.0.6-fzo52dlnsdgyyb3wgxrrlxmnvepk6esa/spack-src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors_memintrinsics.inc:115:5
#1 0x7f0d5b25c311 in FAST_CreateCheckpoint /mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/openfast/modules/openfast-library/src/FAST_Library.f90:445:76
#2 0x7f0d5f5ea22e in fast::OpenFAST::step(bool)
/mnt/vdb/home/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/openfast/glue-codes/openfast-cpp/src/OpenFAST.cpp:1436:17
```
This PR fixes this error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few more changes for
DbKi = R8Kibehavior, especially on Windows:DBLEto REAL(*,R8Ki) to avoid possible issues when default double is specified as other than 8 bytesDCM_expRandDCM_SetLogMapForInterpRand other routines in NWTC_Num.f90