Add support for remoteFolder:serverName and for 'ftp' vs 'smb' in remoteFolder:type#5
Open
jma89 wants to merge 1 commit intodesjardinsm:mainfrom
Open
Add support for remoteFolder:serverName and for 'ftp' vs 'smb' in remoteFolder:type#5jma89 wants to merge 1 commit intodesjardinsm:mainfrom
jma89 wants to merge 1 commit intodesjardinsm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says it all, really. I added the property field/parameter for serverName as that's used when saving an FTP destination. I also added a parameter for flipping the entry type from SMB to FTP, leaving it with a default value of SMB for backwards-compatibility.
I haven't done any automated testing since I don't have the setup for that, but it does appear to work properly in my environment. (This is my first code-level contribution to any project, so please pardon any faux pas here.)