Skip to content

Conversation

@saschagrunert
Copy link
Contributor

@saschagrunert saschagrunert commented Feb 7, 2019

Hey, I think it would be a valuable addition to disable fixing when linting is disabled. WDYT?

I will fix the tests if the general change is accepted by you.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@w0rp
Copy link
Member

w0rp commented Feb 7, 2019

No, you should still be able to fix your files when linting is disabled. If you want to turn both off, turn both off.

@w0rp w0rp closed this Feb 7, 2019
@saschagrunert
Copy link
Contributor Author

Okay, may I ask you how to temporarily disable linting in ale? :) There seems no command for that, right?

@w0rp
Copy link
Member

w0rp commented Feb 8, 2019

There is a command for that. :help ALEDisable.

@FuDesign2008
Copy link

But there is no command to disable fixing when let g:ale_fix_on_save=1 is set in .vimrc.
let g:ale_fix_on_save = 0 can disable fixing when saving file on next time. Can ale provide a command like ALEFixDisable ?

command! -nargs=0 ALEFixDisable :let g:ale_fix_on_save=0

@saschagrunert saschagrunert deleted the fix-disable branch August 23, 2019 11:27
@saschagrunert
Copy link
Contributor Author

But there is no command to disable fixing when let g:ale_fix_on_save=1 is set in .vimrc.
let g:ale_fix_on_save = 0 can disable fixing when saving file on next time. Can ale provide a command like ALEFixDisable ?

command! -nargs=0 ALEFixDisable :let g:ale_fix_on_save=0

That's what I initially meant 👍 😇

@w0rp
Copy link
Member

w0rp commented Sep 20, 2019

I don't think there's a need for a command like that. The let line is enough. The only reason :ALEDisable exists is so you can both disable linting, remove autocmd commands, and clear any linter problems that have been set so far.

@FuDesign2008
Copy link

In order to not keep g:ale_fix_on_save in my mind, I build FuDesign2008/ale-shim.vim .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants