Skip to content

fix(ext/node): throw invalid state from getAuthTag #29752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
littledivy merged 1 commit into from
Jun 16, 2025
Merged

fix(ext/node): throw invalid state from getAuthTag #29752

littledivy merged 1 commit into from
Jun 16, 2025

Conversation

@littledivy
Copy link
Member

@littledivy littledivy commented Jun 15, 2025

Part 1 towards enabling parallel/test-crypto-authenticated.js

Ref #29637

@littledivy littledivy mentioned this pull request Jun 15, 2025
Open
81 tasks
kt3k
kt3k approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ref https://github.com/nodejs/node/blob/d6dade5bc5faf32c8efce69cbc385ca3383beef7/lib/internal/crypto/cipher.js#L186

@littledivy littledivy merged commit c9de072 into denoland:main Jun 16, 2025
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kt3k kt3k kt3k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@littledivy @kt3k