fix(ext/node): fix EventEmitter.on
#29682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/node/polyfills/_events.mjs
Outdated
| return new SafeMap(); | ||
| } | ||
| return new SafeMap( | ||
| Object.entries(data.listeners).map(( |
Contributor
There was a problem hiding this comment.
Nit: use primordial for Object.entries().
ext/node/polyfills/_events.mjs
Outdated
| // This is necessary to pass `paralle/test-events-on-async-iterator.js` test | ||
| // TODO(kt3k): This can be removed if events.getEventListeners() is used | ||
| // instead of `signal[kEvents]` in upstream. | ||
| Object.defineProperty(signal, kEvents, kEventsGetter); |
Contributor
There was a problem hiding this comment.
Nit: use primordial for Object.defineProperty
marvinhagemeister
approved these changes
Jun 11, 2025
Contributor
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
LGTM, two small nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
EventEmitter.onbehaviors and enablesparallel/test-events-on-async-iterator.jstest case.Details:
EventEmitter.onwasn't working. This PR fixes it.signal[kEvents]field if AbortSignal is passed toEventEmitter.onto let abort signal simulate Node.js EventTarget behavior. This field is used in the test case.optionsobject inEventEmitter.ontowards #29595