Skip to content

fix(ext/node): make conditional exports work in require() #29640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bartlomieju merged 4 commits into from
Jun 10, 2025
Merged

fix(ext/node): make conditional exports work in require() #29640

bartlomieju merged 4 commits into from
Jun 10, 2025

Conversation

@bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jun 6, 2025 •
edited
Loading

This commit fixes passing conditional exports specified with
--unstable-node-conditions flag to require() calls.

Fixes scenario from #23757 (comment)

@nayeemrmn nayeemrmn requested a review from dsherret June 7, 2025 16:14
dsherret
dsherret approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju changed the title fix(ext/node): pass conditional exports to ops fix(ext/node): make conditional exports work in require() Jun 10, 2025
@bartlomieju bartlomieju merged commit ccc30ed into denoland:main Jun 10, 2025
18 checks passed
@bartlomieju bartlomieju deleted the conditional_exports_fix branch June 10, 2025 00:09
@bartlomieju bartlomieju mentioned this pull request Jun 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsherret dsherret dsherret approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartlomieju @dsherret @nayeemrmn