fix(ext/node): pass node.js specific flags via NODE_OPTIONS env var in spawn #29600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the interpretation of command line args when
child_process.spawnis called withDeno.execPath()executable.We modify cli args for
spawn(process.execPath, ...)call to simulate Node.js cli. This PR adds the handling of--pending-deprecationflag. Now if--pending-deprecationis specified, it's set toNODE_OPTIONSenv var of the child process, which correctly affects the printing of deprecation warning of Buffer constructor.towards #29589