Skip to content

fix(ext/node): support DEP0005 deprecation warning #29530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kt3k merged 19 commits into from
Jun 4, 2025
Merged

fix(ext/node): support DEP0005 deprecation warning #29530

kt3k merged 19 commits into from
Jun 4, 2025

Conversation

@kt3k
Copy link
Member

@kt3k kt3k commented May 30, 2025 •
edited
Loading

This PR adds support of DEP0005 warning which is emitted when the user calls Buffer as constructor.

enables 3 compat cases:

  • test-buffer-constructor-deprecation-error.js
  • test-buffer-constructor-outside-node-modules.js
  • test-buffer-pending-deprecation.js

ramaining:

  • pass compat test case

@kt3k kt3k added the ci-draft Run the CI on draft PRs. label Jun 2, 2025
@kt3k kt3k force-pushed the fix-ext-node-buffer-DEP0005 branch from 9875e6e to b07bd3a Compare June 2, 2025 06:25
@kt3k kt3k requested a review from bartlomieju June 4, 2025 01:00
@kt3k kt3k marked this pull request as ready for review June 4, 2025 01:00
@kt3k kt3k mentioned this pull request Jun 4, 2025
Closed
13 tasks
littledivy
littledivy approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@kt3k kt3k merged commit ff8160b into denoland:main Jun 4, 2025
18 of 22 checks passed
@kt3k kt3k deleted the fix-ext-node-buffer-DEP0005 branch June 4, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees

No one assigned

Labels

ci-draft Run the CI on draft PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kt3k @littledivy