Skip to content

Conversation

@littledivy
Copy link
Member

@littledivy littledivy commented May 30, 2025

Fixes parallel/test-buffer-from.js in daily Node compat tests runs. The test was already enabled in CI but that used a different helper than the daily Node compat tests runners - updated now.

divy@divy-macbook deno % deno -A ./tools/node_compat_tests.js -f parallel/test-buffer-from
Found 0 sequential tests and 1 parallel tests
Running 1 tests
   1 FAIL parallel/test-buffer-from.js
    FAIL parallel/test-buffer-from.js
    exit code: 1
    error: Uncaught (in promise) AssertionError: Values are not equal:


    [Diff] Actual / Expected


-   The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received type function ([Function (anonymous)])
+   The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received function


    at new AssertionError (ext:deno_node/assertion_error.ts:412:11)
    at toNode (node:assert:48:15)
    at deepStrictEqual (node:assert:267:3)
    at validateThrownError (node:assert:622:9)
    at throws (node:assert:104:9)
    at file:///Users/divy/gh/deno/tests/node_compat/runner/suite/test/parallel/test-buffer-from.js:59:3
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (file:///Users/divy/gh/deno/tests/node_compat/runner/suite/test/parallel/test-buffer-from.js:51:3)
    at Object.<anonymous> (file:///Users/divy/gh/deno/tests/node_compat/runner/suite/test/parallel/test-buffer-from.js:146:4)
    at Module._compile (node:module:745:34)

Filtered tests: 0/1 (0.00%)
Elapsed time: 0.20s
divy@divy-macbook deno % target/debug/deno -A ./tools/node_compat_tests.js -f parallel/test-buffer-from
Found 0 sequential tests and 1 parallel tests
Running 1 tests
   1 PASS parallel/test-buffer-from.js
    PASS parallel/test-buffer-from.js
Filtered tests: 1/1 (100.00%)
Elapsed time: 0.40s

The test was already enabled in CI but that uses a different helper than the daily Node compat tests runners
@littledivy littledivy changed the title fix(ext/node): fix function error message in invalidArgTypeHelper fix(ext/node): fix function error message in invalidArgTypeHelper May 30, 2025
@littledivy littledivy changed the title fix(ext/node): fix function error message in invalidArgTypeHelper fix(ext/node): fix function error message in invalidArgTypeHelper May 30, 2025
@littledivy littledivy requested review from bartlomieju and kt3k May 30, 2025 04:54
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@littledivy littledivy merged commit ba9c80e into denoland:main May 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants