Skip to content

fix(ext/node): correct kMaxLength value of node:buffer #29504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kt3k merged 2 commits into from
May 30, 2025
Merged

fix(ext/node): correct kMaxLength value of node:buffer #29504

kt3k merged 2 commits into from
May 30, 2025

Conversation

@kt3k
Copy link
Member

@kt3k kt3k commented May 29, 2025

This PR fixes kMaxLength value of node:buffer. This change allows test-buffer-alloc.js case passing.

marvinhagemeister
marvinhagemeister approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 4a80e1d into denoland:main May 30, 2025
18 checks passed
@kt3k kt3k deleted the fix-ext-node-buffer-alloc-test branch May 30, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kt3k @marvinhagemeister @bartlomieju