Conversation
Contributor
jeffra
commented
Nov 1, 2022
jeffra
commented
- SD benchmark scripts
- SD tutorial showing how to deploy and evaluate a deployment
- Add MII package version that can be checked at runtime
- Fix GPRC max message size issue that I ran into when running multi-batch SD
- Added optional mii config to skip model validation checks (this currently takes >15sec and is not always needed)
mrwyattii
approved these changes
Nov 2, 2022
Contributor
mrwyattii
left a comment
mrwyattii
left a comment
There was a problem hiding this comment.
LGTM, just a few minor suggestions to tutorial
A bit of restructuring
Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
|
I'd recommend you mention how many steps are taken for the benchmark comparison. Same with image dimensions. Both really impact throughput. Maybe try compare variations like 512x512 vs 1024x1024. I didn't immediately find it so apologies if I missed it too. |
Contributor
Author
|
Thank you @Suhail for the feedback, I’ll update the tutorial before merging to add this info. One thing for anyone reading this PR, we have pending changes coming later today on the DeepSpeed side related further performance updates and bug fixes. We’ll merge this PR once those our live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.