Open
Conversation
![github-advanced-security[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
nemunaire
force-pushed
the
integration-gdrive
branch
from
ece6064 to
cba4107
Compare
Even using the official Google Drive integration, you can't access JPGs or PNGs, so I don't think it should be a focus |
Probably google has some documentation, and then just point the user to where to input some tokens. |
I investigated this and I found that I can't get the icon pictured to show up in 2.15.1.1189 (latest toltec) or 3.5.2.1807 (latest stable). Neither with a shared folder to a specific account, or a shared via a link anyone can access. The google drive web page shows the "shared folder" icon so I think that would be a scenario where it would be shown in the remarkable as well. I looked at the network traffic as well and I didn't see anything that would indicate changing a folder icon. For these reasons I don't think its worth while to pursue this icon feature anymore. It's possibly discontinued by remarkable and the field is no longer sent to the clients. The older versioned clients may still respect it, but there is no way to tell anymore. |
image/png base64 encoded. resolution: 156x220 Example: Request: Response: Open this link in your browser to view the image: |
nemunaire
force-pushed
the
integration-gdrive
branch
2 times, most recently
from
d019821 to
4c5b597
Compare
Collaborator
Author
|
Hi @NotNotQuinn! Thanks for your investigations! I just update my PR to include thumbnail retrieval, it works well for PDF, but not for google documents. Is this the same with the official integration? I use this patch on my own instance since June. Once a week (exactly 1 week after the integration creation), the token seems to expire unexpectedly. Initially the |
This isn't the case. On the official integration you can see previews for pdfs, google docs, google sheets, and google slides. Also, I wanted to mention:
This doesn't show up in the official google drive integration either. It feels like it should, and it would be cool if it did, but it doesn't. |
nemunaire
added a commit
to nemunaire/rmfakecloud
that referenced
this pull request
Oct 17, 2023
Update messages.IntegrationMetadata struct as mention in ddvk#241 (comment)
Merged
nemunaire
added a commit
to nemunaire/rmfakecloud
that referenced
this pull request
Aug 6, 2024
Update messages.IntegrationMetadata struct as mention in ddvk#241 (comment)
nemunaire
force-pushed
the
integration-gdrive
branch
4 times, most recently
from
fb4ba9f to
338115d
Compare
nemunaire
force-pushed
the
integration-gdrive
branch
from
338115d to
a4a0bb5
Compare
nemunaire
force-pushed
the
integration-gdrive
branch
from
a4a0bb5 to
fe59e33
Compare
|
I see that this is in draft, but, it seems like this has had no activity in 2+ years? The readme mentions it is a WIP though. Is there help needed for this or is this considered closed? It would be nice to use GDrive for this if at all possible. |
Collaborator
Author
|
This patch works well to retrieve documents and thumbnails. Also it lacks documentation about the creation of the OAuth application in Google Console. |
nemunaire
force-pushed
the
integration-gdrive
branch
from
fe59e33 to
181a2c4
Compare
nemunaire
force-pushed
the
integration-gdrive
branch
from
181a2c4 to
8be2dce
Compare
Collaborator
Author
|
I found the issue: the token was not saved into user profile after refresh. It needs to be tested for more than a week to validate the changes. |
nemunaire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Google Drive integration (it respond partially to #102). It depends on #240, and extends it a bit.
It features:
To finish my work, I need to find the answer to the following questions:
There is a dedicated icon to highlight shared drives (penultimate image on https://support.remarkable.com/s/article/Integrating-with-Google-Drive-Dropbox-and-OneDrive): what is the key missing for that inapparently notmessage.IntegrationFile? (seems to be added in 2.13)message.IntegrationFile?To do:
Understand why the doc told us JPG, PNG are supported, but they are reported as "Not compatible" with their official MIME type. Are they converted? How?seems not compatible after allLet my know if you have some hints, requests, ...