Deleted call to removeItem after being processed #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used your plugin on a vue.js application where it was being used multiple times in the same window.
E.g imagine a list of results. Each result had an element inside that was using whenInViewport to determine if it had been scrolled past or not.
I had a lot of issues because it seems that whenever an item was scrolled past, it was removed so if the user scrolled back up, then down again, it wouldn't be detected. (Or may be there was another issue, I can't remember, but there definitely was something)
Removing this line fixed the issue for me. I've been using my fixed version for a year or so, just came across this and thought I should contribute.