Revert "use J as a binary instead of loading the module ( 120 + MBs )"#89
Merged
dbashford merged 1 commit intodbashford:masterfrom Jun 27, 2016
Merged
Conversation
This reverts commit 6e35e0a.
Owner
|
I'd rather at least check to see if it can be found either at the project root or where it's looking now before falling back to loading it in. And if executing things in another process was wrong, textract has bigger issues :) |
Owner
|
FYI, just started a new job this week so may be until the weekend before I get back to it. |
Contributor
Author
Heh. I was only referring to running Other things I would say to support this change are:
|
Owner
|
Played with this a little, happy to go back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6e35e0a made in #22
As I mentioned in a comment on that pull request the way npm v3 flattens dependencies means we can no longer rely on the j binary being in a consistent location relative to this package. I also think executing J in a separate process is the wrong way to go.
This change necessarily breaks #37 as well however without it
textractcan't be used as a dependency within another project to extract text from spreadsheets