Issue 3 crashes found by honggfuzz#6
Merged
yoshuawuyts merged 6 commits intodatrs:masterfrom Jun 7, 2018
Merged
Conversation
Give up if an unknown algorithm name is encountered. According to docs, the allowed algorithm names are "BLAKE2b", "Ed25519" and "".
yoshuawuyts
approved these changes
Jun 7, 2018
Contributor
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
This looks fantastic. Thank you!
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Fixes #3 by adding more checks to the parser. I have incorporated all the changes from the nom based parser (#4):
BLAKE2b,Ed25519and""(empty string). According to the docs these three are the allowed ones.Honggfuzz does not find problems with this parser.
Checklist
Semver Changes
Possibly minor level because of the stricter parsing but patch level should be fine too.